fix: url needs std specified to compile idna #2302
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idna dep of url is failing to compile on stable because default_features is false. std is a default feature that disables the unstable use of error_in_core. error[E0658]: use of unstable library feature 'error_in_core' error: could not compile `idna` (lib) due to previous error rust-lang/rust#103765 https://github.com/servo/rust-url/blob/main/url/Cargo.toml#L35
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2302 +/- ##
=====================================
Coverage 79.6% 79.6%
=====================================
Files 123 123
Lines 21263 21263
=====================================
+ Hits 16938 16940 +2
+ Misses 4325 4323 -2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
idna dep of url is failing to compile on stable because default_features is false. std is a default feature that disables the unstable use of error_in_core.
rust-lang/rust#103765
https://github.com/servo/rust-url/blob/main/url/Cargo.toml#L35
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial, user-facing changes